Corinna Vinschen <vinsc...@redhat.com> : > On Sep 5 14:18, rom...@fr.zoreil.com wrote: [...] > > - rtl_reset_counters_cond induced failures in open() are also considered > > fatal: it takes acceptable work to unwind comfortably. > > Why?
Crap, my description does not match the code wrt rtl_reset_counters_cond. :o/ s/rtl8169_reset_counters/rtl8169_update_counters/g The code is right. [...] > This returns -EINVAL even for older chip versions which are not capable > of resetting the counters. The result is, this driver will not work at > all on chip versions prior to RTL_GIGA_MAC_VER_19 anymore, because > rtl_open will always fail. No. My changelog was misleading. rtl_init_counter_offsets handles this part correctly. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
