On Sep 6 22:21, Francois Romieu wrote: > Corinna Vinschen <vinsc...@redhat.com> : > > On Sep 5 14:18, rom...@fr.zoreil.com wrote: > [...] > > > - rtl_reset_counters_cond induced failures in open() are also considered > > > fatal: it takes acceptable work to unwind comfortably. > > > > Why? > > > Crap, my description does not match the code wrt rtl_reset_counters_cond. :o/ > > s/rtl8169_reset_counters/rtl8169_update_counters/g > > The code is right. > > [...] > > This returns -EINVAL even for older chip versions which are not capable > > of resetting the counters. The result is, this driver will not work at > > all on chip versions prior to RTL_GIGA_MAC_VER_19 anymore, because > > rtl_open will always fail. > > No. My changelog was misleading. rtl_init_counter_offsets handles this part > correctly.
Oh, right, I missed that rtl_init_counter_offsets checks for `if (!rc)', not for `if (rc < 0)' as for the call to rtl8169_update_counters. Still wondering though. Given that the driver never failed before if the counter values couldn't be updated, and given that these counter values only have statistical relevance, why should this suddenly result in a fatal failure at open time? Corinna
pgpU8NPcDgH_n.pgp
Description: PGP signature
