On Mon, 2013-05-20 at 17:27 -0700, Stephen Hemminger wrote: > On Mon, 20 May 2013 23:37:28 +0200 > Francois Romieu <rom...@fr.zoreil.com> wrote: > > > cp_stop_hw includes netdev_reset_queue. > > > > You have imho exhibited a start_xmit after cp_stop_hw race - not sure if > > it happens in cp_tx_timeout or cp_change_mtu. Reverting the analysis above, > > I have not found a place where cp_stop_hw could be called without being > > followed by a cp_clean_rings. The netdev_reset_queue in cp_stop_hw, now > > useless, should thus be removed. > > > > Does it make sense ? > > Your right, you could probably remove it. > > It doesn't solve the problem, still seeing transmit timeouts. > Looks like what happens with DHCP is something else.
Did you ever work this out? I'm seeing something similar on the inward -facing interface on my home router under high load — and it doesn't automatically recover. [308309.340644] ------------[ cut here ]------------ [308309.345379] WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0x103/0x190() [308309.352789] Hardware name: Geos [308309.356020] NETDEV WATCHDOG: eth1 (8139cp): transmit queue 0 timed out [308309.362733] Modules linked in: sch_fq_codel sch_teql gpio_keys_polled leds_gpio geodewdt solos_pci ledtrig_heartbeat gpio_cs5535 cs5535_clockevt 8139cp ip6t_REJECT ip6t_rt ip6t_hbh ip6t_mh ip6t_ipv6header ip6t_frag ip6t_eui64 ip6t_ah ip6table_raw ip6table_mangle ip6table_filter ip6_tables nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_irc nf_conntrack_irc nf_nat_ftp nf_conntrack_ftp xt_HL xt_hl xt_ecn ipt_ECN xt_CLASSIFY xt_time xt_tcpmss xt_statistic xt_mark xt_length xt_DSCP xt_dscp cs5535_mfgpt cs5535_mfd mfd_core ipt_MASQUERADE nf_nat xt_recent xt_helper xt_connmark xt_connbytes pptp l2tp_ppp pppoe xt_conntrack xt_CT iptable_raw xt_state nf_conntrack_ipv4 nf_defrag_ipv4 nf_conntrack pppox pppoatm ipt_REJECT xt_TCPMSS xt_comment xt_multiport xt_mac xt_limit iptable_mangle iptable_filter ip_tables xt_tcpudp x_tables nsc_gpio ip_gre gre sit l2tp_netlink l2tp_core ppp_mppe tunnel4 tun ppp_async ppp_generic slhc br2684 atm crc_ccitt ipv6 input_polldev msr input_core sha1_generic geode_aes ecb arc4 aes_i586 ohci_hcd ehci_hcd usbcore usb_common [308309.457239] Pid: 0, comm: swapper Not tainted 3.7.1 #1 [308309.462463] Call Trace: [308309.465020] [<c10272e7>] ? warn_slowpath_common+0x87/0xb0 [308309.470691] [<c11e3d43>] ? dev_watchdog+0x103/0x190 [308309.475755] [<c10273a3>] ? warn_slowpath_fmt+0x33/0x40 [308309.481159] [<c11e3d43>] ? dev_watchdog+0x103/0x190 [308309.486244] [<c11e3c40>] ? pfifo_fast_dequeue+0xd0/0xd0 [308309.491751] [<c1030f3c>] ? call_timer_fn.isra.42+0x1c/0x80 [308309.497422] [<c11d1394>] ? process_backlog+0x54/0xe0 [308309.502674] [<c10310ca>] ? run_timer_softirq+0x12a/0x160 [308309.508169] [<c11e3c40>] ? pfifo_fast_dequeue+0xd0/0xd0 [308309.513697] [<c102cfcd>] ? __do_softirq+0x6d/0x110 [308309.518675] [<c102cf60>] ? __tasklet_schedule+0x40/0x40 [308309.524178] <IRQ> [<c102d121>] ? irq_exit+0x31/0x60 [308309.529359] [<c1003c7d>] ? do_IRQ+0x8d/0xb0 [308309.533723] [<c1003c7d>] ? do_IRQ+0x8d/0xb0 [308309.538201] [<c1254fe9>] ? common_interrupt+0x29/0x2e [308309.543440] [<c1050000>] ? rt_mutex_adjust_prio_chain+0x180/0x280 [308309.549829] [<c10085c4>] ? default_idle+0x14/0x30 [308309.554719] [<c1008e1f>] ? cpu_idle+0x2f/0x50 [308309.559259] [<c131e878>] ? start_kernel+0x286/0x28b [308309.564414] [<c131e440>] ? repair_env_string+0x4d/0x4d [308309.569729] ---[ end trace 2e18cc211cee6089 ]--- [308309.574551] 8139cp 0000:00:0b.0 eth1: Transmit timeout, status c 2b 0 80ff -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
