On Tue, 2016-03-01 at 14:48 -0500, David Miller wrote: > From: Ben Hutchings <b...@decadent.org.uk> > Date: Tue, 01 Mar 2016 17:14:06 +0000 > > > On Tue, 2016-03-01 at 11:42 -0500, David Miller wrote: > >> From: Nicolas Dichtel <nicolas.dich...@6wind.com> > >> Date: Tue, 1 Mar 2016 16:20:41 +0100 > >> > >> > DIV_ROUND_UP and is defined in linux/kernel.h only for the kernel. > >> > INT_MAX > >> > needs limits.h in userland. > >> > >> It is wrong to provide a definition of this in the user visible global > >> namespace. > > > > Which is why he's not doing that... > > No, that's exactly what he's doing: > > +#ifndef __KERNEL__ > +#include <limits.h> /* for INT_MAX */ > +#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) > +#endif > > in a uapi header file. > > "If not kernel, define DEV_ROUND_UP"
Sorry, as there was already a v2 which doesn't do this, I thought you were responding to that. Ben. -- Ben Hutchings If God had intended Man to program, we'd have been born with serial I/O ports.
signature.asc
Description: This is a digitally signed message part
