Thanks! I'll apply the patch and fix the issues you pointed out and then resubmit the patchset.
-Brad On Fri, Nov 25, 2011 at 7:47 AM, ghe. rivero <[email protected]> wrote: > Just one last comment: I don't know if it's packaging or python stuff to do, > but, plugins don't load due to a missing __init__.py file in the plugins dir > (/usr/lib/python2.7/dist-packages/quantum/plugins) With an empty one is > enough. > Ghe Rivero > PD- is it possible to do a review of a review? or how to send a patch to a > review? Anyway, find attached a setup_sample_plugin.py. With all this, the > review will be complete and correct to me. > > On Thu, Nov 24, 2011 at 2:56 PM, ghe. rivero <[email protected]> wrote: >> >> Everything looks fine so far, just a couple of comments: >> 1.- There is a setup.py missing for the sample plugin (it existed before). >> Nothing necessary. >> 2.- Now, having all setupX.py at the same dir, if you build and install >> one, and then, build/install a second one, without cleaning the first, the >> second install also installs the files from the first one, cause every build >> happens in the same dir. It can be easy solved using a --build-base >> parameter for each one, but it's not as straight as in "python setup_xX.py >> install" >> Ghe Rivero >> >> On Thu, Nov 24, 2011 at 7:28 AM, ghe. rivero <[email protected]> wrote: >>> >>> Wow! That was quick! I'll take a look this morning. >>> Ghe Rivero >>> >>> On Thu, Nov 24, 2011 at 2:36 AM, Brad Hall <[email protected]> wrote: >>>> >>>> Thanks for the feedback.. Here is a review for the changes: >>>> https://review.openstack.org/#change,1886 >>>> >>>> Thanks, >>>> Brad >>>> >>>> On Wed, Nov 23, 2011 at 2:28 PM, Chris Wright <[email protected]> >>>> wrote: >>>> > * Dan Wendlandt ([email protected]) wrote: >>>> >> On Wed, Nov 23, 2011 at 2:03 PM, ghe. rivero <[email protected]> >>>> >> wrote: >>>> >> > Absolutly. I only hope that the change happens not so close to the >>>> >> > final >>>> >> > essex release. Anyway, if you need a hand, I'm willing to help. >>>> >> >>>> >> I think this is key. Let's really focus on getting these changes in >>>> >> for >>>> >> essex-2 so people can have packaging solidified well in advanced of >>>> >> the >>>> >> main essex release. >>>> > >>>> > Agreed. And happy to help out here too. >>>> > >>>> > thanks, >>>> > -chris >>>> > >>>> > -- >>>> > Mailing list: https://launchpad.net/~netstack >>>> > Post to : [email protected] >>>> > Unsubscribe : https://launchpad.net/~netstack >>>> > More help : https://help.launchpad.net/ListHelp >>>> > >>>> >>>> -- >>>> Mailing list: https://launchpad.net/~netstack >>>> Post to : [email protected] >>>> Unsubscribe : https://launchpad.net/~netstack >>>> More help : https://help.launchpad.net/ListHelp >>> >>> >>> >>> -- >>> .''`. Pienso, Luego Incordio >>> : :' : >>> `. `' >>> `- www.debian.org www.hispalinux.es >>> >>> GPG Key: 26F020F7 >>> GPG fingerprint: 4986 39DA D152 050B 4699 9A71 66DB 5A36 26F0 20F7 >> >> >> >> -- >> .''`. Pienso, Luego Incordio >> : :' : >> `. `' >> `- www.debian.org www.hispalinux.es >> >> GPG Key: 26F020F7 >> GPG fingerprint: 4986 39DA D152 050B 4699 9A71 66DB 5A36 26F0 20F7 > > > > -- > .''`. Pienso, Luego Incordio > : :' : > `. `' > `- www.debian.org www.hispalinux.es > > GPG Key: 26F020F7 > GPG fingerprint: 4986 39DA D152 050B 4699 9A71 66DB 5A36 26F0 20F7 > > -- > Mailing list: https://launchpad.net/~netstack > Post to : [email protected] > Unsubscribe : https://launchpad.net/~netstack > More help : https://help.launchpad.net/ListHelp > > -- Mailing list: https://launchpad.net/~netstack Post to : [email protected] Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
