Hey Robert, Good catch! I'll file a bug to move the extensions to the cisco plugin directory.
Thanks, Brad On Tue, Nov 29, 2011 at 9:59 AM, Robert Kukura <[email protected]> wrote: > On 11/28/2011 07:07 PM, Brad Hall wrote: >> >> OK, the changes are in. The directory tree is now back to the old >> structure which should make life easier for the distros for packaging. >> Thanks,Brad >> On Wed, Nov 23, 2011 at 5:36 PM, Brad Hall<[email protected]> wrote: >>> >>> Thanks for the feedback.. Here is a review for the changes: >>> https://review.openstack.org/#change,1886 >>> >>> Thanks, >>> Brad > > So far it looks like this layout with the separate setup_*.py scripts for > each sub-package will work fine for fedora packaging. > > I noticed that all of the quantum.extension classes, which are in the common > package, attempt to import cisco_exceptions and cisco_faults from > quantum.plugins.cisco.common. The cisco_exceptions and cisco_faults classes > don't currently get installed with any package, but seem to belong in > cisco_plugin. Wouldn't that introduce cross dependencies between common and > cisco_plugin. Should the extensions be moved to cisco_plugin, or to a > separate cisco_extensions package that depends on cisco_plugin? Or should > the quantum.plugins.cisco.common stuff go in common? I'm relatively new to > quantum and openstack, so apologies if I'm missing something obvious. > > -Bob > > > -- > Mailing list: https://launchpad.net/~netstack > Post to : [email protected] > Unsubscribe : https://launchpad.net/~netstack > More help : https://help.launchpad.net/ListHelp > -- Mailing list: https://launchpad.net/~netstack Post to : [email protected] Unsubscribe : https://launchpad.net/~netstack More help : https://help.launchpad.net/ListHelp
