2009/4/6 Daniel Silverstone <[email protected]>: > Could anyone who has a patch pending related to the GTK stuff, please > follow-up directly to this message (on-list, not to me personally) and I > will see what I can do. Thanks.
Here's my patch-package: * Added: Local history button in toolbar * Added: context menu for links in browser window: "Open link in new tab" (opens url in new, active tab) and "Open link in background" (just open url in new tab). * Change: Local History window is: - smaller by default, - positioned relative to mouse pointer, - transient for main window, - slightly transparent. * Change: by default new tab is: - blank with title "New Tab", - added at the end of tabs list, - set as active in notebook container. * Change : urlbar gets focus on new tab. * Change: parameter bool new_tab -> int new_tab_option in functions related to browser_window (to allow opening tab in background or, in the future, in specified position). Known issues: * Present in rev 7027: creating a new tab generates GTK-Critical on Netsurf exit: > (nsgtk:18651): GLib-GObject-WARNING **: invalid uninstantiatable type > `(null)' in cast to `GtkWidget' > (nsgtk:18651): Gtk-CRITICAL **: gtk_widget_set_size_request: assertion > `GTK_IS_WIDGET (widget)' failed > (nsgtk:18651): GLib-GObject-WARNING **: invalid uninstantiatable type > `(null)' in cast to `GtkWidget' > (nsgtk:18651): Gtk-CRITICAL **: gtk_widget_queue_draw: assertion > `GTK_IS_WIDGET (widget)' failed > (nsgtk:18651): GLib-GObject-CRITICAL **: g_object_set: assertion `G_IS_OBJECT > (object)' failed * NS_NEW_TAB_FOCUS, NS_NEW_TAB_BACKGROUND - not really an issue, but I'm wondering: is this a good naming convention? ToDo: * Check that error. * Either make Local History window more compact (no frame; self-resizeable [probably requires an extension in history_core.c]; close button or onclick close event) or change it to display text list when invoked by history button click [Comments, thoughts?]. * LH as a tab. Also there's an important update regarding my GSoC application - I can fully commit to the project. Turns out I won't be able to meet a minimum of 3 months internship duration requirement - semester in in the abroad university I was accepted in starts 01.09.2009. -- Rigards, Chris Tarnowski. ------------------------------- PGP Key-Id: C33C A45D IRC: _3d1
local_history_and_new_tabs.patch
Description: Binary data
<<attachment: arrow_down_8x32.png>>
