Hello Chris On 04.08.09, you wrote:
> On Tue, 04 Aug 2009 18:28:52 +0100, John-Mark Bell wrote: > >> On Tue, 2009-08-04 at 18:15 +0100, Chris Young wrote: >>> On Mon, 03 Aug 2009 22:07:06 -0000, wrote: >>> >>>> URL: http://source.netsurf-browser.org?rev=9027&view=rev >>>> Log: >>>> Stop utterly insane palette entry population. >>>> Palette entries are always ABGR, regardless of platform endianness. >>>> This change probably breaks big-endian platforms which, under the >>>> old approach, had palette entries of the form RGBA (assuming I >>>> understood the code correctly). >>> >>> Yes it does, and it totally breaks NetSurf* as GIFs now have a >>> different byte order to every other bitmap. >>> >>> Can we either change all the bitmap outputs to ABGR or (preferably) >>> leave them all as RGBA please? >> >> Colour component ordering is orthogonal to endianness, so the current >> mess within NetSurf (and, apparently, libns*) whereby bitmap component >> ordering depends on the CPU's endianness is insane. > > I do kind of agree with this, but component ordering is linked to > endianness to some degree, and the screen format here is "big endian" > (ARGB), and I take it on little endian systems the screen format is > reversed (BGRA or ABGR). Although I stand to be corrected on this, it > seems sensible to keep the format as close to the destination format > as possible to save unnecessary bit-shifting. what does scout show what pixel Format your OS4 use ? on amiga 68k there is BGRA used or 16 bit PC, its see on Big Endian systems that GFX Card is access in little endian, because there are graphic Chips out, that cant switch in Big Endian mode. on AOS 68k its more easy when all is done in ABGR, because there need only a shift of 8 left or right. currently the format is RGBA for netsurf images, that cost more performance to convert, because the trick 2 pixel alphablend at once do not work.the trick only work, if in bit 0-8 and bit 16-24 are pixels.so the pixel must shift 8 to right. but anyway the pixel format is not so important i do tests(disable image blits), much more time netsurf do on xml process group frame and i think CSS Regards
