On Thu, 06 Aug 2009 09:42:19 +0200, Bernd Roesch wrote:

> I see in new plotter API in wiki here 
> 
> http://wiki.netsurf-browser.org/Plotter-api
> 
> bool (*bitmap)(void *pw, const plot_rect *rect, struct bitmap *bitmap,
> colour_t bg_colour, bitmapf_t flags);
> 
> but currently 32 bit plotters in libnsfb have this.(i check out today
> newest)
> 
> bitmap(nsfb_t *nsfb,
>        const nsfb_bbox_t *loc,
>        const nsfb_colour_t *pixel, 
>        int bmp_width, 
>        int bmp_height, 
>        int bmp_stride,
>        bool alpha)
> {
> 
> maybe it is planned in the new plotter API to add pixelformat bits on flags.
> ?.
> then the plotter can choose correct one.

Maybe.  They are both completely different to the current API in
trunk.

However, I tink it is really bitmap_create() which needs to know what
the pixel format is.  It can then be stored for later use by the
plotter.

This would be a satisfactory stop-gap while the component order is in
an inconsistent state, but it's still messy.

I can add a flag to the bitmap_create flags but have no idea what to
call it (BITMAP_BGRA might be confusing)

Suggestions for naming welcomed, and then at least it can be worked
around.

Regards
Chris

Reply via email to