In message <[email protected]> Michael Drake <[email protected]> wrote:
> In article <[email protected]>, > Matthew Hambley <[email protected]> wrote: >> In message <1249852601.14617.93.ca...@duiker> >> John-Mark Bell <[email protected]> wrote: [snip] >>> UI themeing. Much voodoo I've never comprehended. Also includes >>> toolbars, which should be made into a standalone component, imo. >> It is a bit of a mess. I think the problem comes from an assumption >> that button bars are the only thing which will ever be themed. >> Therefore the two concepts form one big gooey splat of code. > Toolbars are the only thing that can be themed, because we weren't that > fond of the idea of theming, since it over complicates things. :) Themes > are really just a set of images for toolbar icons. I guess most of the > "theme" stuff would be more aptly named "toolbar". I have to admit to being surprised when I first looked at Netsurf all those years ago. I thought it odd that apparently the first thing considered with the project was theming. But then I have an old fashioned view on these matters. I'd rather a well designed interface be provided than a slap-dash one which is "okay because you can theme it". However as John-Mark Bell says: > There's two, completely orthogonal things going on in that code: > > 1) A toolbar widget (and its corresponding editor) > 2) Management of theme data. > > In the interests of my sanity, these should be separated. Which I would endorse. -- (\/)atthew )-(ambley [ Public key: C991137B ]
