On Thu, 2011-12-01 at 22:49 +0000, John-Mark Bell wrote: > I've had a relatively quick look through it. It appears mostly fine, but > it's been a while since I last looked at the CSS3 Fonts module. I'll > endeavour to give it a proper look at the weekend.
Ok. I've been through it and committed it as r13244. Mostly, it involved code style cleanups, a bunch of fixes for the parser to make it match the spec better[1], and some memory leak fixes. WRT: /* It seems a little weird to me that the standard specifies * that the format is a comma seperated list. How can a font at * a specific location have more than one fomat? [JRM]. */ If fetched over HTTP, content negotiation can result in multiple formats being hosted at the same URL. Thanks, J. 1. By my reading of the grammar, it's never permissible to follow local(foo) with a format(...) specifier
