On 4 Dec 2011, at 21:09, John-Mark Bell wrote: > On Thu, 2011-12-01 at 22:49 +0000, John-Mark Bell wrote: > >> I've had a relatively quick look through it. It appears mostly fine, but >> it's been a while since I last looked at the CSS3 Fonts module. I'll >> endeavour to give it a proper look at the weekend. > > Ok. I've been through it and committed it as r13244. > > Mostly, it involved code style cleanups, a bunch of fixes for the parser > to make it match the spec better[1], and some memory leak fixes.
Thanks. I've looked through the diffs to my original code, they all look good to me. I really appreciate the time you put into this. > WRT: > > /* It seems a little weird to me that the standard specifies > * that the format is a comma seperated list. How can a font at > * a specific location have more than one fomat? [JRM]. > */ > > If fetched over HTTP, content negotiation can result in multiple formats > being hosted at the same URL. Ah, I guess that makes sense. In my head, a font of a different format would be a different 'resource' (especially in my world of ebooks where they're a file on disk), but I guess that's not really the case if they're the same design. Although, are user-agents expected to only accept the font formats they can display when making e.g. an HTTP request for the font? I suspect many won't... Again, thanks for taking the patch. I'm enjoying using and working with libCSS, it's a great piece of work. Jamie.
