Nicolas Mora <nico...@babelouest.org> writes: > I've updated the code with the new bswap_if_le and removed the > commented code.
Hi, I haven't been paying attention to this for a few weeks, but I've had a nother look now. I've left a few comments on the MR. For testing, it's important to test both in-place operation (that should be supported, right? Following the conventions documented at https://www.lysator.liu.se/~nisse/nettle/nettle.html#Conventions), and separate input and output area. For the tests of unwrap, it is important to test the error case, i.e., try changing some bit in the input, and verify that unwrap returns an error. The new feature also needs documentation, will you look into that once code, and in particular the interfaces, are solid? Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list nettle-bugs@lists.lysator.liu.se http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
