Nicolas Mora <nico...@babelouest.org> writes: > I've added test cases to verify that unwrap fail if the input values > are incorrect [1]. I reuse all the unwrap test cases, changed one > ciphertext byte and expect the unwrap function to return 0.
I've merged the latest version of https://git.lysator.liu.se/nettle/nettle/-/merge_requests/19 to the master-updates branch, with some minor changes (moved function typedefs out of nettle-types.h, and indentation fixes to nist-keywrap.h. Thanks for your contribution and patience. >> Or possibly under "7.3 Cipher modes", if it's too different from the >> AEAD constructions. >> > Until we come to a solution on where to put the documentation, I've > started a first draft for the documentation. Can you give me feedback > on it? I think putting it under cipher modes probably makes the most sense. The function reference looks good, it doesn't have to be a lot of text. Please spell "cipher" consistently, not "cypher". In the introduction, you write "Its intention is to provide an algorithm to wrap and unwrap cryptographic keys.". Is it possible to give a bit more details, some guidance on when it is a good idea to use this key wrapping rather than a more general AEAD algorithm? If there's some interesting background, or examples of protocols that use aes keywrap, that could also go here. I think it would also be nice to clarify that the spec defines the key wrapping as an aes-specific mode, but Nettle's implementation supports any block cipher with a block size of 16 bytes. > Also, I've never used LaTex. What tool do you recommend to write LaTex > documentation? I've tried gummi but it says there are errors in the > nettle.texinfo file... Texinfo is not quite the same as LaTeX, even if it uses the same TeX machinery for the typeset pdf version. Manual is here: https://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html, but I think you can mostly go by the examples elsewhere in the Nettle manual, and check the docs only for the markup you need. You probably need to grasp the @node thing, though. See https://www.gnu.org/software/texinfo/manual/texinfo/texinfo.html#Writing-a-Node (the nettle manual uses the old-fashined way with explicit node links). I edit it in emacs, like any other file. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list nettle-bugs@lists.lysator.liu.se http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
