hi folks we'll be closing out the review in a few days- i've posted an updated webrev at
http://cr.grommit.com/~amaguire/onnv-quagga-updated/ it includes changes for all the code review comments, bar one - i've left the pidfiles for routing daemons that cannot be converted to SMF in /var/tmp. to recap, these pidfiles are necessary for the status output of "routeadm" (run with no arguments) - they are used to check if the process associated with the daemon in question is still running. keeping them in /var/tmp removes the need to modify the configuration on upgrade for users who specified /var/tmp as the pidfile location in the past. as i mentioned, all this applies only to routing daemons that cannot be upgraded to their smf counterparts (and once quagga integrates into sfw, the zebra daemons will have smf counterparts in the shape of the quagga services too). one other minor change from last time - i thought it'd be possible to get rid of the project-private -F (update forwarding settings only and do not write configuration out) flag in routeadm, but it turns out we need to preserve the "do not write configuration out" behaviour, since it is run sufficiently early in boot that the root filesystem may not be writable. also, you'll notice there's a lot more files, and an additional bug id (CR 6440342). these cover meem's suggestion of adding make targets to Makefile.targ at the toplevel - doing this allows a lot of redundancies to be removed from smf Makefiles. thanks again to everybody who participated in the review! alan This message posted from opensolaris.org _______________________________________________ networking-discuss mailing list [email protected]
