On Thu, Nov 09, 2006 at 06:00:31PM -0500, Peter Memishian wrote:
>
> David and Renee,
>
> To make your jobs easier, I've built an alternate webrev that shows just
> the changes to ath(7D) from the version that Venu reviewed earlier:
>
> http://cr.grommit.com/~meem/wifi-1018-diff
>
> This reduces the amount of change that needs review to 382 lines. If you
> could review this ASAP, we would be quite grateful :-)
Many thanks for the alternate webrev! My comments are below.
Apologies for the slow response...again.
-renee
-------------------------------------------------------------------------------
FEEDBACK ON TECHNICAL DOCUMENTATION/CODE
-------------------------------------------------------------------------------
Reviewer Name: Renee Danson
Document/Module Title: wifi-1018-diff
Document/Module Version/Date: 11/10/06
No comments:
usr/src/uts/common/io/ath/ath_impl.h
-------------------------------------------------------------------------------
usr/src/uts/common/io/ath/ath_aux.c
-------------------------------------------------------------------------------
RD-17 289-290 Cos You should be able to merge these two lines.
RD-18 298-299 Com I'm puzzled by the if conditional and the
comment; they don't seem to match. And I can't
find the implementation of ath_hal_mhz2ieee to
figure out what ix really is. This is probably
okay, I'm just confused; but I'd like to
understand it!
RD-19 704 Cos Typo: "reseting" should be "resetting"
-------------------------------------------------------------------------------
usr/src/uts/common/io/ath/ath_hal.h
-------------------------------------------------------------------------------
RD-20 108 Com typo: "interference used for as AR..." Probably
need to delete the 'as'.
RD-21 265 Com The comment for this line is a dup of that on
the line above; I don't think that's right.
RD-22 279-280 Func Just to be sure: it's intentional that the
first two items in the enum are set to 0x0001?
RD-23 320-322 Com I don't understand the second sentence of this
comment; the word 'no' seems misplaced, but I
can't quite figure out how it should read.
RD-24 335-336 Com There's an extra 'to' in there.
RD-25 528, 529 Com The comments for these two lines seem to be
swapped.
RD-26 760, 761 Com You didn't change this, but the comments for
these two lines seem to be swapped, as well.
-------------------------------------------------------------------------------
usr/src/uts/common/io/ath/ath_main.c
-------------------------------------------------------------------------------
RD-27 1133 Com typo: "descariptor" should be "descriptor"
-------------------------------------------------------------------------------
Comment type key:
Func comment on functionality
Perf comment on performance
CodeStd comment on coding standards
Design comment on design
Edit editorial comment
Cos cosmetic comment
Com comment on missing comments
_______________________________________________
networking-discuss mailing list
[email protected]
