Sagun Shakya wrote:
webrev against last code review:
http://cr.grommit.com/~sshakya/libdlpi-webrev-review1/

Two cosmetic nit-picks:

usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_capture.c:

* 155, 206, 212: cstyle: need brackets


usr/src/lib/libdlpi/common/libdlpi.c:

* 1384: I'd prefer to see the DLPI macro names for these types here instead of their constant values. For example, DL_ETHER instead of 0x04, etc.

Thanks,
-Seb
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to