On Wed, 10 Dec 2008 09:51:17 -0500 "Anurag S. Maskey" <[email protected]> wrote:
> Just a reminder that I am looking for code review comments to integrate > this fix. I have already submitted the manpage bug (CR 6783378) to get > dladm(1M) updated. The webrev is at > http://cr.opensolaris.org/~anurag_m/onnv-bug-6766937/. This looks fine. The only comment I have is that you validate the name before creating it and output a message when the name is invalid but in the following delete function (and possible other places) I think some invalid secure object names would end up causing a different error string. It isn't necessarily part of this bug but it would be nice to validate names consistently throughout dladm. mph > > Thanks, > Anurag > > -------- Original Message -------- > > As discussed in this thread, I've updated libdladm so that invalid > > characters are not allowed in secure object names (only alphanumeric, > > underscore '_', period '.', and hyphen '-' are allowed). The name is > > validated before secure objects are created. > > > > I've also updated nwamd so that invalid characters are not used in the > > secure object names. These invalid characters are simply ignored. > > > > Webrev is at: > > > > http://cr.opensolaris.org/~anurag_m/onnv-bug-6766937/ > > > > Earlier Jim had said: > > > >> > - The CR evaluation doesn't explain _why_ space is illegal here. > >> > What makes it so? (I'm guessing that it's used in some file > >> > format somewhere, but the Evaluation field should give the details > >> > about what's wrong, so that we know what's being fixed.) > >> > > I've updated the Evaluation in the CR to reflect the causes of this bug. > > > > Below is the new text for the explanations of "link" and "secobj" names > > in dladm(1M). After review, I'll submit a manpage CR to have the > > descriptions updated. > > > > link > > > > A datalink, identified by a name. In general, the name may > > use any alphanumeric characters (or the underscore), but must > > start with an alphabetic character and end with a number. A > > datalink name may be at most 32 characters, and the ending > > number may be at most 16 characters. Datalink names between > > 3 and 8 characters are recommended. > > > > secobj > > > > A secure object, identified by an administratively-chosen > > name. The name may use any alphanumericcharacters, as well > > as underscore ('_'), period ('.'), or hyphen ('-'). A secure > > object name may be at most 32 characters. > > > > > > I'd appreciate code review comments and comments on the descriptions for > > the manpage bug. > > > > Thanks, > > Anurag > > > > _______________________________________________ > > networking-discuss mailing list > > [email protected] > > > _______________________________________________ > networking-discuss mailing list > [email protected] _______________________________________________ networking-discuss mailing list [email protected]
