On Tue, 16 Dec 2008 10:02:35 -0500 "Anurag S. Maskey" <[email protected]> wrote:
> > > > >> Just a reminder that I am looking for code review comments to integrate > >> this fix. I have already submitted the manpage bug (CR 6783378) to get > >> dladm(1M) updated. The webrev is at > >> http://cr.opensolaris.org/~anurag_m/onnv-bug-6766937/. > >> > > > > This looks fine. The only comment I have is that you validate the name > > before creating it and output a message when the name is invalid but in > > the following delete function (and possible other places) I think some > > invalid secure object names would end up causing a different error > > string. It isn't necessarily part of this bug but it would be nice to > > validate names consistently throughout dladm. > > > > mph > > > You are right that the message will be different and say that it can't > find the secure object. The show- and delete-secobj work on previously > created secure objects which already have a valid name, OK, I thought maybe they could be invalid as they looked like they came off the command line. > so anything else > is non-existent. Maybe a new CR to have consistent name validation in > dladm (dladm_valid_linkname() is also used only for create-* functions) Sure. mph . > > Anurag > > _______________________________________________ > networking-discuss mailing list > [email protected] _______________________________________________ networking-discuss mailing list [email protected]
