> > > libresolv2 files - http://cr.opensolaris.org/~posnake/libresolv2-v0.5/

 - usr/src/lib/libresolv2/Makefile:82-102

   Leaving targets commented out does us no good :)  Just blow that
   away, and since that'd leave you with nothing bracketed by the
   CRYPT/EXPORT DELETE START/END, might as well delete those too.


 - usr/src/lib/libresolv2/Makefile:42

   Is anything else building the 'irs' stuff now?  If not then just
   delete all the irs stuff too.  Ah, I see some does get referenced
   elsewhere.

   If I'm reading this right it looks like all the sources referenced by
   the old IRSDYNOBJS makefile macro in
   usr/src/lib/libresolv2/Makefile.com can be deleted.  Is that right?


 - usr/src/lib/libresolv2/include/res_update.h:30,90

       30 +/*! \file */
       31 +

   What's this comment for?


 - usr/src/lib/libresolv2/include/res_update.h:33-34

       33 +#ifdef  ORIGINAL_ISC_CODE
       34 +#else
       35 +/* definition of u_int32_t needed on Solaris */
  33   36  #include <sys/bitypes.h>
       37 +#endif

   Er, use #ifndef to replace 33-34 with just one line:

       33 +#ifndef  ORIGINAL_ISC_CODE
       34 +/* definition of u_int32_t needed on Solaris */
  33   35  #include <sys/bitypes.h>
       36 +#endif

   Same thing at 43-43.  No?  Or is this a convention in ISC code?


More later.
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to