On 06/19/09 01:14, Nicolas Williams wrote:


 - usr/src/lib/libresolv2/include/res_update.h:33-34

       33 +#ifdef  ORIGINAL_ISC_CODE
       34 +#else
       35 +/* definition of u_int32_t needed on Solaris */
  33   36  #include <sys/bitypes.h>
       37 +#endif

   Er, use #ifndef to replace 33-34 with just one line:

       33 +#ifndef  ORIGINAL_ISC_CODE
       34 +/* definition of u_int32_t needed on Solaris */
  33   35  #include <sys/bitypes.h>
       36 +#endif

   Same thing at 43-43.  No?  Or is this a convention in ISC code?

It was a convention started by Ulf Ekberg when he maintained DNS software at Sun. In recent years we've begun to drop it.

Stace
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to