Michael Hunter wrote:

Begin forwarded message:

Date: Mon, 06 Jul 2009 15:36:11 -0700
From: Michael Hunter <[email protected]>
To: [email protected]
Subject: [nwam-dev] NWAM Phase 1 Code Review request


This is a request for people to review the NWAM Phase 1 code.

The code can be found at http://cr.opensolaris.org/~mph/nwam1_cr/

I've only looked at the new user creation, and the RBAC profile parts:

DJM-1 user_attr why aren't dladm,netadm,netcfg marked as roles ? Users shouldn't login to them directly right (yes I know they have locked accounts)

DJM-2 SUNWcrnet/postinstall  how is this going to be done in an IPS world ?

DJM-3 i.passwd the change for dladm's group doesn't look like it will work for upgrade, see how I did the home dir change for the gdm user.

--
Darren J Moffat
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to