> > * 28-36: nit: Rejustify the comment to wrap at 79 columns and it
> > should format a bit better.
> >
> > * 170: Default disposition of SIGTHAW is SIG_IGN, so this seems
> > unnecessary.
> >
> >
> sure. I also tidied up the Makefile in line with
> your other suggestions - see:
>
> http://zhadum.east.sun.com/export/ws/amaguire/nwam1-bugs/webrev/
netcfgd/Makefile now has:
clean:
$(RM) $(PROG)
The `clean' target is not supposed to remove "final" objects like this.
That is, the `clean' target should be empty.
No need for `include ../../Makefile.msg' either.
For netcfg.c:
* 51-52, 86: Should be static.
* 70-79: Any reason not to fold this into nlog()?
* 155: Would prefer to properly grab the last component of the
path (e.g., see ipmpstat.c lines 198-201), and then use this
instead of hardcoded strings at lines 100 and 102.
--
meem
_______________________________________________
networking-discuss mailing list
[email protected]
