On (08/10/09 13:54), Sebastien Roy wrote:
> > 3672 } else if (ill->ill_net_type == IRE_IF_NORESOLVER) {
> > 3673 /*
> > 3674 * NORESOLVER entries are always created in the
> > REACHABLE
> > 3675 * state.
> > 3676 */
> > 3677 if ((template = copyb(ill->ill_resolver_mp)) ==
> > NULL) {
> > 3678 err = ENOMEM;
> > 3679 goto err_ret;
> > 3680 }
> > 3681 state = ND_REACHABLE;
> > 3682 }
> >
> > This section, if it detects IFF_POINTOPOINT, should copy the
> > ill_dest_addr to nce->nce_res_mp->b_rptr + NCE_LL_ADDR_OFFSET(ill)
>
> ill_resolver_mp already contains the right information. I can say
Ok, maybe a comment to that effect would be useful to have.
> set correctly for both IPv4 and IPv6 ill_t's, so I'll need to get back
> to you on what the use of ill_dest_addr is about in the ndp_noresolver()
> call to ndp_lookup_then_add_v6().
Ok.
Rest of the review responses are ok with me.
--Sowmini
_______________________________________________
networking-discuss mailing list
[email protected]
