On Mon, 2009-08-10 at 13:56 -0400, [email protected] wrote:
> Rest of the review responses are ok with me.
> 

Thanks.  I had an embedded question in one of my earlier responses:

> > 
> > - Question: line 605: why is the explicit dladm_init_linkprop needed
> >   (as opposed to just having the dls layer suck down the properties)?
> 
> ACCEPT: This same code exists in i_dladm_aggr_up().  I assumed that it
> was necessary in order for the properties to get applied.  What should I
> do instead?  Do the properties automatically get applied if I don't call
> this function?

Looking through dls_devnet_set(), it looks like this call can simply be
removed, and the same can be said about the code in i_dladm_aggr_up().
I suppose I can file a buglet on the i_dladm_aggr_up() call and fix it
while I'm here.  What say you?

Thanks again,
-Seb


_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to