On Thu, 2007-06-07 at 16:08 +0100, Jon Escombe wrote: > ----- "Dan Williams" <[EMAIL PROTECTED]> wrote: > > > > Attaching a new version of my patch, this checks whether a private > > key file is configured for the connection before attempting to read a > > password from the keyring. I believe this should suit both of the > > above 802.1X configuration types.. > > > > Wouldn't this not change the behavior for Tomas? Since his config > > doesn't show a private key file, it seems like your patch won't change > > behvior for him. > > > > I guess we should get him to test the patch first and see :) > > > > In any case, I've committed your fix since it's obviously correct. I > > added a bit to make sure we free the private_key_file variable since > > that's actually allocated memory. > > > > Dan > > > > Thanks, > > I believe Tomas is using 6.4, which doesn't work (for him) because it always > tries to get a password from the keyring. 6.5 includes a patch to never get a > password from the keyring (which I'm assuming would work for Tomas - but > breaks the private key password scenario). This *should* now be the best of > both worlds ;)
Ah, ok. Can you test out latest SVN for 0.6.x and confirm that I didn't break anything when modifying your patch? Thanks, Dan _______________________________________________ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list