On Thu, 07 Jun 2007 17:08:41 +0200, Jon Escombe <[EMAIL PROTECTED]> wrote:
> > ----- "Dan Williams" <[EMAIL PROTECTED]> wrote: > >> > Attaching a new version of my patch, this checks whether a private >> key file is configured for the connection before attempting to read a >> password from the keyring. I believe this should suit both of the >> above 802.1X configuration types.. >> >> Wouldn't this not change the behavior for Tomas? Since his config >> doesn't show a private key file, it seems like your patch won't change >> behvior for him. >> >> I guess we should get him to test the patch first and see :) >> >> In any case, I've committed your fix since it's obviously correct. I >> added a bit to make sure we free the private_key_file variable since >> that's actually allocated memory. >> >> Dan >> > > Thanks, > > I believe Tomas is using 6.4, which doesn't work (for him) because it > always tries to get a password from the keyring. 6.5 includes a patch to > never get a password from the keyring (which I'm assuming would work for > Tomas - but breaks the private key password scenario). This *should* now > be the best of both worlds ;) > > Regards, > Jon. > _______________________________________________ > NetworkManager-list mailing list > NetworkManager-list@gnome.org > http://mail.gnome.org/mailman/listinfo/networkmanager-list I am afraid I will not be able to confirm this (although I think ou are right) since it does not compile with my version of NM (0.6.4): applet-dbus-info.c: In function ‘nmi_dbus_get_key_for_network’: applet-dbus-info.c:193: error: ‘NM_AUTH_TYPE_LEAP’ undeclared (first use in this function) applet-dbus-info.c:193: error: (Each undeclared identifier is reported only once applet-dbus-info.c:193: error: for each function it appears in.) I tried to install the current svn, but it did not work for some reason (no idea what reason). I found the patch (http://mail.gnome.org/archives/networkmanager-list/2006-July/msg00034.html) that introduces LEAP into NM, but it does not work with my source anyway since it is far too huge. I hope it work anyway. Sorry and regards, Tomas _______________________________________________ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
