Hi all, Please code review the following fix: http://cr.opensolaris.org/~aragorn/6888022-grpid/
Background ========== nfs4_create() function lacks the grpid mount flag handling in nfs4open_otw(). On the other side the nfs4_mkdir() function calls for directory creation call_nfs4_create_req() function. The call_nfs4_create_req() handles properly the grpid flag for directories. The fix adds request to set the gid into the OPEN operation in case when grpid mount flag (MI4_GRPID) is used. The idea of the fix is same as the code used in call_nfs4_create_req() where the directory creation is handled. Unit test ========= I unit tested the fix on both sparc and x86 machines with all possible combinations of - NFS version (2, 3, 4) - grpid mount flag used/not used - setgid bit set/not set for a directory owning the newly created file/directory Thank you. -- Marcel Telka Solaris RPE
