It looks good!. I did notice the following however:
usr/src/lib/libfsmgt/common/nfs_mntinfo.c and usr/src/cmd/fs.d/nfs/ nfsstat/nfsstat.c don't use the MI4_* defines, which is okay since (for example) MI4_GRPID and MI_GRPID have the same value. At a minimum we should add a comment to nfs4_clnt.h that states the "dependency" .. (around line 1039..) Robert. On Oct 21, 2009, at 10:06 AM, Marcel Telka wrote: > Hi all, > > Please code review the following fix: > http://cr.opensolaris.org/~aragorn/6888022-grpid/ > > Background > ========== > > nfs4_create() function lacks the grpid mount flag handling in > nfs4open_otw(). > On the other side the nfs4_mkdir() function calls for directory > creation > call_nfs4_create_req() function. The call_nfs4_create_req() handles > properly > the grpid flag for directories. > > The fix adds request to set the gid into the OPEN operation in case > when grpid > mount flag (MI4_GRPID) is used. The idea of the fix is same as the > code used in > call_nfs4_create_req() where the directory creation is handled. > > Unit test > ========= > > I unit tested the fix on both sparc and x86 machines with all > possible combinations of > - NFS version (2, 3, 4) > - grpid mount flag used/not used > - setgid bit set/not set for a directory owning the newly created > file/directory > > > Thank you. > > -- > Marcel Telka > Solaris RPE > _______________________________________________ > nfs-discuss mailing list > nfs-discuss at opensolaris.org
