William Allen Simpson wrote on Mon, Jun 22, 2015 at 03:26:38PM -0400:
> Moreover, requiring library changes adds more variability to
> the mix. The only patch that matters (to me) is the final patch.
I'd agree if we squash them after review, but since we don't, anyone
bisecting do care about all the individual commits.
This has nothing to do with gerrit but with any workflow, I know kernel
maintainers do build with all individual patches one at a time (Anna has
a script that does for NFS)
> >Anyway, I'm sorry your patches didn't get in last week, there's a
> >trivial conflict on rebase to new tip in "Remove unused nfs_worker_data
> >parameters" -- I fixed it in my github's next.
>
> Especially as I'd been able to shuffle the errant "->" to "."
> change into the correct patch. Oh well, another time.
>
> Please only post changes tracking the post you want to fix, as
> there doesn't seem to be a diff from mine to yours.
Attached it. I wanted to include it in my first mail but it was too big
to send inline along with another mail.
> Moreover, it's best not to squash patches from multiple sources.
> If you have a patch to a patch, just add it to the chain.
I can't, because then would have one commit that does not build (again).
Please re-apply my patch yourself if you care - it comes straight out of
a git diff of both branches (my next and your gerrithub tip)
--
Dominique
diff --git a/src/Protocols/9P/9p_xattrwalk.c b/src/Protocols/9P/9p_xattrwalk.c
index b708f6e..65bfe92 100644
--- a/src/Protocols/9P/9p_xattrwalk.c
+++ b/src/Protocols/9P/9p_xattrwalk.c
@@ -205,45 +205,12 @@ int _9p_xattrwalk(struct _9p_request_data *req9p, u32
*plenout, char *preply)
&attrsize);
if (FSAL_IS_ERROR(fsal_status)) {
+ gsh_free(pxattrfid->specdata.xattr.xattr_content);
+ gsh_free(pxattrfid);
- /* Hook dedicated to ACL management. When attributes
- * system.posix_acl_access is used, it can't be
- * created, but can be written anyway.
- * To do this, return ENODATA instead of ENOATTR
- * In this case, we do created what's needed to
- * setxattr() into the special xattr */
- if (fsal_status.minor == ENODATA) {
- if (!strncmp(name,
- "system.posix_acl_access",
- MAXNAMLEN))
- attrsize = 0LL;
- else if (!strncmp(name,
- "security.selinux",
- MAXNAMLEN))
- attrsize = 0LL;
- else {
- gsh_free(pxattrfid->specdata.
- xattr.xattr_content);
- gsh_free(pxattrfid);
- return _9p_rerror(req9p,
- msgtag,
- ENODATA,
- plenout,
- preply);
- }
- } else {
- gsh_free(pxattrfid->specdata.
- xattr.xattr_content);
- gsh_free(pxattrfid);
-
- return _9p_rerror(req9p,
- msgtag,
- _9p_tools_errno
- (cache_inode_error_convert
- (fsal_status)),
- plenout,
- preply);
- }
+ /* fsal_status.minor is a valid errno code */
+ return _9p_rerror(req9p, msgtag, fsal_status.minor,
+ plenout, preply);
}
}
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
