Hi, ----- Original Message ----- > From: "William Allen Simpson" <william.allen.simp...@gmail.com> > To: "Matt Benjamin" <mbenja...@redhat.com> > Cc: d...@redhat.com, nfs-ganesha-devel@lists.sourceforge.net > Sent: Friday, March 10, 2017 2:21:41 PM > Subject: Re: [Nfs-ganesha-devel] UDP duplicate cache in both Ganesha and > ntirpc? > > On 3/9/17 1:44 PM, Matt Benjamin wrote: > > But, isn't su_cache...NULL? > > > Aha, I see that you are correct. It is only set non-NULL in > svc_dg_enablecache(), and that's never called. Anywhere. > > So we have this useless facility that I (and Malahal) have been > trying to keep up-to-date with changes, and I've recently fixed > the XXX !MT-SAFE (e89139b), and that's all for nought. > > We don't cache TCP. We don't cache RDMA. > > This code is an anachronism, and needs to be purged with extreme > prejudice. It was badly written, and it's a shame to keep fixing.
Well, it is what it is. Pretty durn old, and never used in nfs-ganesha, I don't believe. > > If we get rid of it, we can use _ioq for output, and get rid of > the extra locks. Don't know how important to speed up UDP, but > we could.... This seems potentially a useful improvement, I wold say, so that provides some positive motivation for gc'ing the legacy cache stuff, I guess. Matt > > -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-821-5101 fax. 734-769-8938 cel. 734-216-5309 ------------------------------------------------------------------------------ Announcing the Oxford Dictionaries API! The API offers world-renowned dictionary content that is easy and intuitive to access. Sign up for an account today to start using our lexical data to power your apps and projects. Get started today and enter our developer competition. http://sdm.link/oxford _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
