Hi, On Tue, Aug 15, 2017 at 8:42 AM, William Allen Simpson <william.allen.simp...@gmail.com> wrote: > On 8/14/17 4:32 PM, Malahal Naineni wrote: >> >> Hi Matt and Bill, we were able to reproduce this crash very easily with a >> sleep after closing "fd" . After my fix, things worked fine. The changes are >> a lot but mostly trivial. Appreciate any high level review. >> > If a hackish band-aid is what you want, that's no skin off my nose.
Malahal's change is sensible and consistent with the intent of the code. It actually fixes the UDP nsm behavior. > > >> ganesha changes (last but one commit at >> https://github.com/ganltc/nfs-ganesha/commits/ibm2.3). >> >> Corresponding ntirpc commit (last commit) >> https://github.com/ganltc/ntirpc/commits/ibm2.3 >> >> On Mon, Aug 14, 2017 at 5:02 PM, Malahal Naineni <mala...@gmail.com >> <mailto:mala...@gmail.com>> wrote: >> >> Unfortunately, I need a fix for this issue against ganesha2.3. >> >> Regards, Malahal. >> >> On Mon, Aug 14, 2017 at 4:18 PM, William Allen Simpson >> <william.allen.simp...@gmail.com <mailto:william.allen.simp...@gmail.com>> >> wrote: >> >> I'm looking at the short-term fix I've mentioned earlier, that we >> should >> try TCP before UDP, but given our current code base doesn't even >> compile, >> I've given up until next week. >> > Well, my investigation should fix all versions. After all, when the code > already explicitly says it wants TCP: > > nsm_clnt = gsh_clnt_create("localhost", SM_PROG, SM_VERS, "tcp"); > > #15 0x71d311 in nsm_connect > /export/nfs-ganesha/src/Protocols/NLM/nsm.c:55:13 > #16 0x722ae9 in nsm_unmonitor_all > /export/nfs-ganesha/src/Protocols/NLM/nsm.c:252:7 > > But ntirpc executes UDP instead: > > #7 0x7ffff58e11c2 in clnt_dg_ncreate > /export/nfs-ganesha/src/libntirpc/ntirpc/rpc/clnt.h:505:10 > #8 0x7ffff58e0e64 in clnt_tli_ncreate > /export/nfs-ganesha/src/libntirpc/src/clnt_generic.c:383:8 > > That surely looks like a serious bug to me! Not respecting the caller's choice of transports is a bug. Matt ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
