On 10/20/2017 07:44 PM, Kaleb S. KEITHLEY wrote:
On 10/20/2017 01:32 PM, Florian Weimer wrote:
----- Original Message -----
+ #if defined(_SC_IOV_MAX) /* IRIX, MacOS X, FreeBSD, Solaris, ... */
+-      __svc_maxiov = sysconf(_SC_IOV_MAX);
++      {
++              /*
++               * some glibc (e.g. 2.26 in Fedora 27 beta) always
++               * return -1
++               */
++              int i = sysconf(_SC_IOV_MAX);
++              if (i != -1 && i > __svc_maxiov)
++                      __svc_maxiov = i;
++      }
+ #endif
+       return true;
+ }

Uh-oh, is this really necessary?

You said it'd be a while before fixed packages make it into Fedora 27.

Yes, there's currently a freeze for the release. For a non-critpath package it might be easier to get the fix out, but I expect that libntirpc will face the same hurdles, which is why I was surprised that you were so eager to patch it.

Without this we're dead in the water.

Sorry, this wasn't clear to me. I pushed fixed packages to updates-testing, but I assume they are going to be stuck there for a while (and we have to respin again for yet another glob security fix).

That aside, I don't understand what the concern is. This is merely
defensive and largely or effectively a no-op.

I strive to fix bugs, rather than papering over them. I hope you can drop the patch again soon. It's clearly a glibc bug.

Thanks,
Florian

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Reply via email to