A few people know this code. One is Frank. I don't immediately see the reason for strong concern, feel free to improve.
Matt On Wed, Nov 1, 2017 at 5:20 AM, William Allen Simpson <william.allen.simp...@gmail.com> wrote: > I'm flummoxed. Who knows this code? > > Problem 1: the timeout is set to 10 microseconds. Holy heck? And > historically, that's the maximum total wait time, so it would try at > least three (3) times within 10 *MICRO*seconds? > > Probably should be milliseconds. > > Problem 2: there's a retry loop that sets up and tears down a TCP > (or UDP) connection 3 times. On top of the 3 tries in RPC itself? > > This looks like a lot of self-flagellation, maybe because the > timeout above was set too short? > > Problem 3: this isn't really async -- nlm_send_async() actually > runs a pthread_cond_timedwait() before returning. That's sync! > > But we already have a timedwait in RPC. And a signal. So this > completely duplicates the underlying RPC library code. Why? > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Nfs-ganesha-devel mailing list > Nfs-ganesha-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-821-5101 fax. 734-769-8938 cel. 734-216-5309 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
