Restating this, the code is unified for tcp v4 and v3. It consults xid and the checksum, which I think is a correct intent. The slot-reply cache in 4.1+ is, we hope, the improved mechanism.
Matt On Tue, Jan 30, 2018 at 9:45 AM, Matt Benjamin <mbenj...@redhat.com> wrote: > I don't think that's the case. the behavior is distinct for v4 and v3 > (which does not have clientids). DRC is bypassed for v4.1+ > > Matt > > On Tue, Jan 30, 2018 at 9:36 AM, William Allen Simpson > <william.allen.simp...@gmail.com> wrote: >> On 1/30/18 9:22 AM, William Allen Simpson wrote: >>> >>> On 1/29/18 3:32 PM, Frank Filz wrote: >>>> >>>> I haven't looked at how the SVCXPRT structure has changed, but if there's >>>> a >>>> field in there we can attach a Ganesha structure to that would be cool, >>>> or >>>> if not, if we could add one. >>>> >>> There are two: xp_u1, and xp_u2. >>> >>> Right now, Ganesha is using xp_u2 for dup request cache pointers. >>> >>> But I've eliminated all old usage of xp_u1 in V2.6. >> >> >> Looking at src/RPCAL/nfs_dupreq.c, I'm not sure why that doesn't already >> have a client or export reference there. It seems we'll return the >> duplicate data to any client that happens to use the same xid. Seems >> like a bug.... >> >> But the code is obscure, so I could be missing something. >> >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Nfs-ganesha-devel mailing list >> Nfs-ganesha-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel > > > > -- > > Matt Benjamin > Red Hat, Inc. > 315 West Huron Street, Suite 140A > Ann Arbor, Michigan 48103 > > http://www.redhat.com/en/technologies/storage > > tel. 734-821-5101 > fax. 734-769-8938 > cel. 734-216-5309 -- Matt Benjamin Red Hat, Inc. 315 West Huron Street, Suite 140A Ann Arbor, Michigan 48103 http://www.redhat.com/en/technologies/storage tel. 734-821-5101 fax. 734-769-8938 cel. 734-216-5309 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Nfs-ganesha-devel mailing list Nfs-ganesha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
