Hi Patrick - I did a code reading of the changed parts - namely (did I miss anything?):
Fixes/changes are only in WhereJoinDetector: a. now using stacks at many places b. Case (j) per our mail exchange c. FixedMapping does ORing when expression occurs multiple times d. override VisitMethodCallExpression, including also "bool only" method call e. "bool only" member expression handling ... and everything looks very correct! (Ah - just to nitpick at *one* place: The error message would be a little bit better if it said "Was expectING a boolean member expression" ;-) ). When I have time during Easter holidays, I'll try to write additional tests that try to (a little bit) stress-test some of the code. I'll use the code in other tests (I try to start working on the Any issue), so it should also get tested there a little. Regards Harald -------- Original-Nachricht -------- > Datum: Mon, 18 Apr 2011 11:27:36 -0600 > Von: Patrick Earl <[email protected]> > An: [email protected] > Betreff: Re: RE: [nhibernate-development] NH-2583 - Query with || operator > and navigations (many-to-one) creates wrong joins > I committed all the new code related to the stack changes and bug > fixes. I'd be happy to have you audit all that Harald. Please also > see if the FixedMapping OR behavior (denoted by comment) is the right > thing to do. The test is fairly complicated and I didn't have time to > analyze it in depth, but it seemed okay off-hand. > > Patrick Earl -- NEU: FreePhone - kostenlos mobil telefonieren und surfen! Jetzt informieren: http://www.gmx.net/de/go/freephone
