Tonight I had some clarity on how the mappings worked. This allowed
me to make some simplifications and fixes. Would be happy to hear
what you think.
Still need to analyze if there's anything else that might convert N to
T, think about the ?: operator, and briefly consider other operators
before I resolve the issue. This issue has been quite a journey. I
hope the result is good.
Looking forward to those other tests you mention. :)
Patrick Earl
On Mon, Apr 18, 2011 at 3:02 PM, Harald Mueller <[email protected]> wrote:
> Hi Patrick -
>
> I did a code reading of the changed parts - namely (did I miss anything?):
>
> Fixes/changes are only in WhereJoinDetector:
> a. now using stacks at many places
> b. Case (j) per our mail exchange
> c. FixedMapping does ORing when expression occurs multiple times
> d. override VisitMethodCallExpression, including also "bool only" method call
> e. "bool only" member expression handling
>
> ... and everything looks very correct! (Ah - just to nitpick at *one* place:
> The error message would be a little bit better if it said "Was expectING a
> boolean member expression" ;-) ).
>
> When I have time during Easter holidays, I'll try to write additional tests
> that try to (a little bit) stress-test some of the code.
>
> I'll use the code in other tests (I try to start working on the Any issue),
> so it should also get tested there a little.
>
> Regards
> Harald
