I agree with Ricardo. I really like the idea, but it should be in a separate project.
/G 2014-12-10 13:47 GMT+01:00 Jeffrey Becker <[email protected]>: > I'll fix this shortly. > On Dec 10, 2014 7:45 AM, "Jan Schubert" <[email protected]> wrote: > >> The fix works great! But the column names are still quoted. I changed >> this and pushed it as a pull request. >> >> Am Dienstag, 9. Dezember 2014 16:59:41 UTC+1 schrieb Jeffrey Becker: >>> >>> Fixes are in and your pull request is merged in the migrations branch. >>> >>> On Monday, December 8, 2014 3:44:15 AM UTC-5, Jan Schubert wrote: >>>> >>>> What exactly would you change in line 404? >>>> >>>> Am Donnerstag, 4. Dezember 2014 20:30:22 UTC+1 schrieb Jeffrey Becker: >>>>> >>>>> The behavior described seems to be centered in Table.GetThreePartName; >>>>> Table.cs Line 404. Stripping out the behavior is causing a lot of >>>>> unit-test failures which I don't have time to address today. >>>>> >>>>> On Thursday, December 4, 2014 2:05:22 PM UTC-5, Jeffrey Becker wrote: >>>>>> >>>>>> I've found it. I'm just stripping it out. >>>>>> >>>>>> On Wednesday, December 3, 2014 11:05:14 AM UTC-5, Jan Schubert wrote: >>>>>>> >>>>>>> I have a problem with the SchemaExport class. Without your changes >>>>>>> for the migration framework, the tables wasn't quoted automaticly. So, >>>>>>> if I >>>>>>> use PostgreSQL as database, the table names are upper case. PostgreSQL >>>>>>> enables uppercase names automaticly, if a name is quoted. I need lower >>>>>>> case >>>>>>> table names for PostgreSQL and CamelCase names for MSSQL table names. I >>>>>>> have the same problem in my "IMigration" class. >>>>>>> >>>>>>> Is it possible to use the auto-quote setting of NHibernate? >>>>>>> >>>>>>> I try to fix the problem, but I can't do this with my insufficient >>>>>>> knowledge. >>>>>>> >>>>>>> PS: The last commit of your branch "migrations" is not compilable. >>>>>>> Some files are missing. >>>>>>> >>>>>>> Am Freitag, 14. November 2014 16:38:44 UTC+1 schrieb Jeffrey Becker: >>>>>>>> >>>>>>>> I'd like some feedback on how people feel about the current state >>>>>>>> of the migrations feature. I've used the existing code in a project >>>>>>>> and it >>>>>>>> seems to work pretty well. That said, I haven't finished all the >>>>>>>> features >>>>>>>> that I originally wanted. The key points I've hit so far are: >>>>>>>> >>>>>>>> >>>>>>>> - Unified DDL generation framework (no weirdness like EF where >>>>>>>> different exports generate different sql) >>>>>>>> - Migration Factory & Version Store >>>>>>>> - Usable Configuration >>>>>>>> - Fluent Builder >>>>>>>> >>>>>>>> That said, generating migrations auto-magically is turning out to >>>>>>>> be much more work than I'd originally anticipated. I think the >>>>>>>> feature is >>>>>>>> definitely achievable, I just don't have the time to do it right now. >>>>>>>> I'm >>>>>>>> proud of what the migrations code-base looks like right now. I think >>>>>>>> its >>>>>>>> the right approach. I'm also concerned about having this sit unmerged >>>>>>>> for >>>>>>>> too long. The longer I'm a fork the more work I have to keep track of >>>>>>>> the >>>>>>>> upstream. Pending some positive feedback and cleanup work I think I'd >>>>>>>> like >>>>>>>> to try to get this merged. Are people comfortable with this? >>>>>>>> >>>>>>> -- >> >> --- >> You received this message because you are subscribed to a topic in the >> Google Groups "nhibernate-development" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/nhibernate-development/aIGssJRjHcw/unsubscribe >> . >> To unsubscribe from this group and all its topics, send an email to >> [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > > --- > You received this message because you are subscribed to the Google Groups > "nhibernate-development" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- --- You received this message because you are subscribed to the Google Groups "nhibernate-development" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
