Vladimír Čunát writes:

> On 01/14/2014 03:01 PM, Eelco Dolstra wrote:
>> But the committer is not shown in GitHub email messages, and tends to get 
>> lost
>> if you do things like cherry-picking into another branch, or commiting a pull
>> request from somebody else.
>
> Github accounts for this "author" wrongly... it collects all with bogus 
> e-mail address (https://github.com/NixOS/nixpkgs/graphs/contributors).
>
> I mainly see the technical problem... it doesn't seem you can use "git 
> am" with committer taken as the author as well. We could generate just 
> diffs instead of patches, but that's more cumbersome to apply, mainly 
> because of commit description.

Please don't, patches are much more convenient.

> Can you see *how* to do this practically?

Nixpkgs-Monitor could get its own email address.

The current approach looks correct to me: Nixpkgs-Monitor is the
original author of the patch, and applying this patch merely makes you
the committer, not the author. 

-- 
Moritz Ulrich

Attachment: pgpIRpZwuADjz.pgp
Description: PGP signature

_______________________________________________
nix-dev mailing list
[email protected]
http://lists.science.uu.nl/mailman/listinfo/nix-dev

Reply via email to