Retested... =)
- npm install works but throws some warnings. You should look into them.
Also I'm not sure which version of node you are targetting. I would advise
optimising for 0.10 for the time being
- `node example/complete.js` fails. readFileSync('./complete.xml')
should read readFileSync(__dirname + '/complete.xml)
- otherwise all examples are working
- I like how you named your tests :D
- in order to make npm aware of your test coverage, add a test script
like described here https://npmjs.org/doc/scripts.html. In your case
that would be "nodeunit test/*.js". Also nodeunit should be in your
devDependencies <https://npmjs.org/doc/json.html#devDependencies> so
it's downloaded an available while runnin npm test.
- that's all. good luck.
On Wednesday, 10 July 2013 14:00:15 UTC+2, Jean-Michel Hiver wrote:
>
> Hello,
>
> I have done quite a bit of debugging, fixed some docs, added examples and
> a test suite. Would you be so kind as to retest and let me know if you spot
> anything fishy? I want to make sure the module works reasonably well before
> pushing it to npm...
>
> Thanks!
>
> Cheers
> JM
>
--
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
---
You received this message because you are subscribed to the Google Groups
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
