Thanks!
My comments below:
> npm install works but throws some warnings. You should look into them.
Also I'm not sure which version of node you are targetting.
> I would advise optimising for 0.10 for the time being
I use a quite old version on node v0.8.17 - yeah yeah i hear the "booos"
but I'd like the module to work with relatively old versions as well as
newer ones.
What errors are you getting?
> - `node example/complete.js` fails. readFileSync('./complete.xml')
> should read readFileSync(__dirname + '/complete.xml)
>
> Aah, very handy! Fixed. Thanks for the tips, my javascript / node
knowledge is still pretty limited.
> - in order to make npm aware of your test coverage, add a test script
> like described here https://npmjs.org/doc/scripts.html. In your case
> that would be "nodeunit test/*.js". Also nodeunit should be in your
> devDependencies <https://npmjs.org/doc/json.html#devDependencies> so
> it's downloaded an available while runnin npm test.
>
> OK, but when I do "npm install" now it pulls nodeunit: is it normal? What
differentiates "dev" from "non dev" mode?
Otherwise "npm test" now works (and passes).
I'll commit your changes to github and try to push the module to npm.
Thanks very much for your help in trying to make something clean!
Cheers
JM
--
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
---
You received this message because you are subscribed to the Google Groups
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
