[
https://issues.apache.org/jira/browse/ACCUMULO-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248687#comment-15248687
]
ASF GitHub Bot commented on ACCUMULO-4195:
------------------------------------------
GitHub user ShawnWalker opened a pull request:
https://github.com/apache/accumulo/pull/95
ACCUMULO-4195 Added generalized configuration objects for RFile interaction
Implemented a builder/fluent style of syntax, where each operation creates
an operation object with both some methods for setting
parameters and an execute() method to actually invoke the operation.
I'm not really sure if this is in line with the improvement the reporter
suggests. It does however address the only goal I can identify with that
request: it should be possible to extend the interface `FileOperations` in a
manner such as was done for ACCUMULO-4187 without requiring significant changes
to unrelated code.
Also, the automatic formatter hates me, and completely undid most of my
eye-pleasing formatting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ShawnWalker/accumulo ACCUMULO-4195
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/95.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #95
----
commit 8917a37a4134a04bb47fac8e14320ea6f1916ed4
Author: Shawn Walker <accum...@shawn-walker.net>
Date: 2016-04-19T19:54:31Z
ACCUMULO-4195 Added generalized configuration objects for RFile interaction.
Implemented a builder/fluent style of syntax, where each operation creates
an operation object with both some methods for setting
parameters and an execute() method to actually invoke the operation.
----
> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>
> Key: ACCUMULO-4195
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4195
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Shawn Walker
> Fix For: 1.8.0
>
>
> Taken from https://github.com/apache/accumulo/pull/90/files#r59489073
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major
> compactions, we noted that many of the changes were related to passing an
> extra argument (RateLimiter) around through all of the code which is related
> to file interaction.
> It would be nice to move to a centralized configuration object instead of
> having to add a new argument every time some new feature is added to the
> file-path.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
