[ https://issues.apache.org/jira/browse/ACCUMULO-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252299#comment-15252299 ]
ASF GitHub Bot commented on ACCUMULO-4195: ------------------------------------------ Github user ShawnWalker commented on a diff in the pull request: https://github.com/apache/accumulo/pull/95#discussion_r60623785 --- Diff: test/src/main/java/org/apache/accumulo/test/proxy/SimpleProxyBase.java --- @@ -2077,7 +2077,8 @@ public void bulkImport() throws Exception { // Write an RFile String filename = dir + "/bulk/import/rfile.rf"; - FileSKVWriter writer = FileOperations.getInstance().openWriter(filename, fs, fs.getConf(), null, DefaultConfiguration.getInstance()); + FileSKVWriter writer = FileOperations.getInstance().openWriter().ofFile(filename, fs, fs.getConf()) + .withTableConfiguration(DefaultConfiguration.getInstance()).execute(); --- End diff -- Within the Accumulo source, the only time that the "default" configuration is the right answer is in tests. Having `FileAccessOperations` provide the default configuration might make writing some tests a tad easier, but at the cost of making it easier to write buggy functional code. > Generalized configuration object for Accumulo rfile interaction > --------------------------------------------------------------- > > Key: ACCUMULO-4195 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4195 > Project: Accumulo > Issue Type: Improvement > Reporter: Josh Elser > Assignee: Shawn Walker > Fix For: 1.8.0 > > > Taken from https://github.com/apache/accumulo/pull/90/files#r59489073 > On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major > compactions, we noted that many of the changes were related to passing an > extra argument (RateLimiter) around through all of the code which is related > to file interaction. > It would be nice to move to a centralized configuration object instead of > having to add a new argument every time some new feature is added to the > file-path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)