milleruntime commented on a change in pull request #1572: Refactor use of
ServerConfigurationFactory
URL: https://github.com/apache/accumulo/pull/1572#discussion_r398673918
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/tabletserver/LargestFirstMemoryManager.java
##########
@@ -121,18 +122,16 @@ public void remove(Long key) {
}
}
- LargestFirstMemoryManager(long maxMemory, int maxConcurrentMincs, int
numWaitingMultiplier) {
- this();
- this.maxMemory = maxMemory;
- this.maxConcurrentMincs = maxConcurrentMincs;
- this.numWaitingMultiplier = numWaitingMultiplier;
+ @Override
+ public void init(ServerConfiguration conf) {
+ throw new IllegalStateException("Deprecated method, no longer should be
used.");
Review comment:
Another option for this update would be to call the new init method:
```init(((ServerConfigurationFactory) conf).getServerContext());```
But I put the exception to prevent calling this in Accumulo. If a user
extends this class, I don't think they should be calling this method. The init
currently gets called in TabletServerResourceManager
[here](https://github.com/apache/accumulo/blob/94844b3ef88bc9e02b5cb5c8eeff81411ac8221d/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java#L432).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
