milleruntime commented on a change in pull request #1572: Refactor use of
ServerConfigurationFactory
URL: https://github.com/apache/accumulo/pull/1572#discussion_r399252881
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/tabletserver/LargestFirstMemoryManager.java
##########
@@ -121,18 +122,16 @@ public void remove(Long key) {
}
}
- LargestFirstMemoryManager(long maxMemory, int maxConcurrentMincs, int
numWaitingMultiplier) {
- this();
- this.maxMemory = maxMemory;
- this.maxConcurrentMincs = maxConcurrentMincs;
- this.numWaitingMultiplier = numWaitingMultiplier;
+ @Override
+ public void init(ServerConfiguration conf) {
+ throw new IllegalStateException("Deprecated method, no longer should be
used.");
Review comment:
I like throwing an exception on the default implementation, not sure why I
didn't just do that.
Sounds like this interface might be a good candidate to move to the SPI
since it deals more with performance and not user data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
