milleruntime commented on a change in pull request #1757:
URL: https://github.com/apache/accumulo/pull/1757#discussion_r513790531
##########
File path:
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
##########
@@ -283,17 +283,18 @@ public static void finishSplit(KeyExtent extent,
* datafilesToDelete are strings because they can be a TabletFile or
directory
*/
public static void addDeleteEntries(KeyExtent extent, Set<String>
datafilesToDelete,
- ServerContext context) {
+ ServerContext context, Ample ample) {
Review comment:
Yes but each call to `context.getAmple()` creates a new object. I added
it as a param to prevent creating objects in the loop over `datafilesToDelete`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
