milleruntime commented on a change in pull request #1757:
URL: https://github.com/apache/accumulo/pull/1757#discussion_r514338305



##########
File path: 
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
##########
@@ -283,17 +283,18 @@ public static void finishSplit(KeyExtent extent,
    * datafilesToDelete are strings because they can be a TabletFile or 
directory
    */
   public static void addDeleteEntries(KeyExtent extent, Set<String> 
datafilesToDelete,
-      ServerContext context) {
+      ServerContext context, Ample ample) {

Review comment:
       Yeah but the code calling this function is in the loop of a scanner and 
it will create a new object for every entry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to