EdColeman commented on a change in pull request #2073:
URL: https://github.com/apache/accumulo/pull/2073#discussion_r624992065



##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1717,7 +1719,7 @@ public void testPertableClasspath() throws Exception {
     fooFilterJar.deleteOnExit();
 
     File fooConstraintJar = File.createTempFile("FooConstraint", ".jar", new 
File(rootPath));
-    
FileUtils.copyInputStreamToFile(this.getClass().getResourceAsStream("/FooConstraint.jar"),
+    
FileUtils.copyInputStreamToFile(this.getClass().getResourceAsStream("/FooConstraint_2_1.jar"),

Review comment:
       Yes - this uses the new interface.  When I tested with something built 
with the older interface it failed.  I think one way to handle this is to add a 
tests that tests a jar built with the each version - step one was just to see 
if this would get the test to pass (which it does now) in case that would help 
point a way forward - this was the motivation to be able to build jars for 
multiple versions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to