ctubbsii commented on a change in pull request #2073:
URL: https://github.com/apache/accumulo/pull/2073#discussion_r628609441
##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -2687,13 +2705,15 @@ public void testCreateTableWithBinarySplitsFile1()
try (AccumuloClient client =
Accumulo.newClient().from(getClientProps()).build()) {
splitsFile = System.getProperty("user.dir") + "/target/splitFile";
generateSplitsFile(splitsFile, 200, 12, true, true, true, false, false);
- SortedSet<Text> expectedSplits = readSplitsFromFile(splitsFile, false);
+ SortedSet<Text> expectedSplits = readSplitsFromFile(splitsFile);
final String tableName = name.getMethodName() + "_table";
ts.exec("createtable " + tableName + " -sf " + splitsFile, true);
Collection<Text> createdSplits =
client.tableOperations().listSplits(tableName);
assertEquals(expectedSplits, new TreeSet<>(createdSplits));
} finally {
- Files.delete(Paths.get(splitsFile));
+ if (Objects.nonNull(splitsFile)) {
Review comment:
Right, but they are only possibly returning null because null is
assigned to the variable first. However, that's an unnecessary assignment. The
assignment inside each try block can be moved to just before the try block, so
they are immediately assigned to the value from reading the system property,
and never assign null in the first place. Then, they can never be null, and you
don't need the checks to see if they are null in the finally blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
