milleruntime commented on issue #2076:
URL: https://github.com/apache/accumulo/issues/2076#issuecomment-839669677
I can see where that would speed up recovery. I haven't done much with
locality groups so not sure how that would work with the sorting of the log
events. I was going with a schema that preserves the current way the WAL events
sort, by Event + tabletId + sequence number:
<pre>
Row = EventTypeInteger_tabletID_seq
Family = event
Qualifier = tserverSession OR filename OR KeyExtent
</pre>
I created the Event type integer based on what is returned by the
compareTo() of `LogFileKey`. Then appended the tabletId integer (which is
written from `commitSession.getLogId()`) and finally the sequence number. The
event type determines what will be stored in the column qualifier.
https://github.com/apache/accumulo/blob/583ca55ceb5402d6bbd0fb093feccc897234582f/server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java#L155-L164
I was using `scanner.fetchColumnFamily(cf);` where the cf could be 0 or many
`Text... colFamToFetch` and passing in the different events to fetch. Maybe I
can put up a draft PR of just the LogFileKey.toKey() method so you can provide
some feedback. There are already a good number of changes but its mostly
changing all the iterators to work with Key/Value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
